Skip to content

Conversation

Signed-off-by: bennett <bennett@umaproject.org>
bmzig and others added 3 commits January 8, 2025 12:22
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
@bmzig bmzig marked this pull request as ready for review January 9, 2025 14:12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this from "zksync" to "zkstack" since I am assuming that the l2 erc20 bridge works the same as in zksync. The native token is GRASS, but it has the same contract address as we have hardcoded in the spoke pool, so I'm assuming that works fine, too. We may need to follow-up with a generalization to the zksync spoke pool if withdrawals do not work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test that the zksync spoke pool withdrawal logic works as expected with this test spoke pool.
Here is a call to _bridgeTokensToHubPool which withdraws grass to l1, and here is a call which withdraws weth to L1.

@bmzig bmzig marked this pull request as draft January 9, 2025 18:14
Signed-off-by: bennett <bennett@umaproject.org>
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sindresorhus/is@0.14.0 None 0 40.2 kB sindresorhus
npm/@szmarczak/http-timer@1.1.2 None 0 6.3 kB szmarczak
npm/@types/minimatch@3.0.5 None 0 8.2 kB types
npm/any-signal@2.1.2 None 0 4.97 kB jacobheun
npm/aws-sign2@0.7.0 None 0 14.2 kB mikeal
npm/aws4@1.11.0 environment 0 22.3 kB hichaelmart
npm/binary-extensions@2.2.0 None 0 5.36 kB sindresorhus
npm/bip66@1.1.5 None 0 7.79 kB dcousens
npm/browser-stdout@1.3.1 None 0 2.3 kB kumavis
npm/bytes@3.1.2 None 0 12.3 kB dougwilson
npm/cacheable-request@6.1.0 network 0 16.8 kB lukechilds
npm/call-bind@1.0.2 None 0 14.7 kB ljharb
npm/caseless@0.12.0 None 0 14.3 kB mikeal
npm/color@3.2.1 None 0 16.6 kB qix
npm/crypto-browserify@3.12.0 None 0 53.5 kB cwmma
npm/decompress-response@3.3.0 None +1 7.12 kB sindresorhus
npm/delayed-stream@1.0.0 None 0 8.02 kB apechimp
npm/drbg.js@1.0.1 None 0 11 kB fanatid
npm/duplexer3@0.1.4 None 0 6.43 kB floatdrop
npm/ee-first@1.1.1 None 0 6.26 kB dougwilson
npm/eth-lib@0.1.29 None 0 92.2 kB evertonfraga
npm/fake-merkle-patricia-tree@1.0.1 None 0 3.54 kB kumavis
npm/find-up@3.0.0 None 0 4.84 kB sindresorhus
npm/forever-agent@0.6.1 network 0 14 kB simov
npm/forwarded@0.2.0 None 0 5.88 kB dougwilson
npm/fs.realpath@1.0.0 environment, filesystem 0 13.4 kB isaacs
npm/get-intrinsic@1.1.1 eval 0 32.5 kB ljharb
npm/global@4.4.0 None 0 3.47 kB raynos
npm/growl@1.10.5 environment, filesystem, shell 0 59.3 kB deiga
npm/har-validator@5.1.5 None 0 8.22 kB ahmadnassri
npm/he@1.2.0 None 0 124 kB mathias
npm/http-response-object@3.0.2 None 0 6.78 kB forbeslindesay
npm/http-signature@1.2.0 network 0 48.4 kB arekinath
npm/iconv-lite@0.4.24 None 0 336 kB ashtuchkin
npm/inflight@1.0.6 None 0 3.76 kB isaacs
npm/ipfs-core-types@0.3.1 None 0 32.2 kB achingbrain
npm/ipfs-core-utils@0.7.2 None 0 49.2 kB achingbrain
npm/ipfs-utils@6.0.8 None +1 87.9 kB achingbrain
npm/ipld-block@0.11.1 None 0 318 kB vmx
npm/ipld-dag-cbor@0.17.1 None 0 161 kB vmx
npm/ipld-dag-pb@0.20.0 None 0 180 kB vmx
npm/ipld-raw@6.0.0 None 0 14.8 kB vmx
npm/is-extglob@2.1.1 None 0 6.22 kB jonschlinkert
npm/is-fn@1.0.0 None 0 2.22 kB sindresorhus
npm/is-function@1.0.2 None 0 4.3 kB grncdr
npm/is-hex-prefixed@1.0.0 None 0 9.44 kB silentcicero
npm/is-typedarray@1.0.0 None 0 4.41 kB hughsk
npm/isarray@1.0.0 None 0 3.89 kB juliangruber
npm/isexe@2.0.0 environment, filesystem 0 11 kB isaacs
npm/isstream@0.1.2 None 0 13.3 kB rvagg
npm/it-last@1.0.6 None 0 2.83 kB achingbrain
npm/it-map@1.0.6 None 0 3.21 kB achingbrain
npm/it-tar@1.2.2 None 0 24.8 kB alanshaw
npm/it-to-stream@0.1.2 None 0 16.7 kB alanshaw
npm/jsonify@0.0.0 None 0 14.7 kB
npm/log-symbols@3.0.0 environment 0 4.11 kB sindresorhus
npm/media-typer@0.3.0 None 0 11.1 kB dougwilson
npm/merge-options@3.0.4 None 0 10.7 kB schnittstabil
npm/micromatch@4.0.4 None 0 61.5 kB danez
npm/mkdirp-promise@5.0.1 None 0 4.63 kB ahmadnassri
npm/mock-fs@4.14.0 filesystem 0 109 kB tschaub
npm/multiaddr@8.1.2 None 0 109 kB vascosantos
npm/native-abort-controller@1.0.4 None 0 2.9 kB achingbrain
npm/node-environment-flags@1.0.6 None 0 26.2 kB boneskull
npm/oauth-sign@0.9.0 None 0 13.8 kB simov
npm/object-assign@4.1.1 None 0 5.49 kB sindresorhus
npm/object-inspect@1.12.0 None 0 90.6 kB ljharb
npm/object.assign@4.1.0 None +1 67 kB ljharb
npm/optionator@0.8.3 None 0 50.1 kB gkz
npm/p-cancelable@1.1.0 None 0 12.5 kB sindresorhus
npm/parse-headers@2.0.4 None 0 6.86 kB kesla
npm/path-is-absolute@1.0.1 None 0 3.62 kB sindresorhus
npm/performance-now@2.1.0 None 0 11.3 kB meryn
npm/raw-body@2.5.2 network, unsafe 0 25.8 kB dougwilson
npm/req-from@2.0.0 None 0 3.66 kB sindresorhus
npm/request-promise-core@1.1.4 None 0 19.7 kB analog-nico
npm/set-immediate-shim@1.0.1 None 0 1.4 kB sindresorhus
npm/source-map@0.2.0 None 0 225 kB nickfitzgerald
npm/stealthy-require@1.1.1 None 0 12.5 kB analog-nico
npm/strip-json-comments@2.0.1 None 0 5.06 kB sindresorhus
npm/sync-rpc@1.3.6 network, shell 0 14.6 kB forbeslindesay
npm/tar@4.4.19 environment, filesystem +1 165 kB isaacs
npm/text-hex@1.0.0 None 0 2.72 kB 3rdeden
npm/then-request@6.0.2 network 0 29.7 kB forbeslindesay
npm/to-readable-stream@1.0.0 None 0 2.79 kB sindresorhus
npm/tough-cookie@2.5.0 network +1 119 kB jstash
npm/tunnel-agent@0.6.0 environment, network 0 16.7 kB mikeal
npm/url-parse-lax@3.0.0 None 0 4.23 kB sindresorhus
npm/util@0.12.4 environment 0 33.6 kB goto-bus-stop
npm/web3-providers-http@1.7.0 network 0 15.2 kB spacesailor
npm/web3-providers-ipc@1.7.0 None 0 22.5 kB spacesailor
npm/web3-providers-ws@1.7.0 None 0 32.5 kB spacesailor
npm/wide-align@1.1.3 None 0 4.55 kB iarna
npm/wrappy@1.0.2 None 0 2.96 kB zkat
npm/xhr-request@1.1.0 None +1 14.6 kB mattdesl
npm/yargs-parser@13.1.2 environment 0 57.1 kB oss-bot
npm/yargs-unparser@1.6.0 None 0 12.1 kB bcoe

🚮 Removed packages: npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/template@7.22.15, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/set-array@1.1.2, npm/@nodelib/fs.scandir@2.1.5, npm/@sinonjs/commons@3.0.1, npm/aggregate-error@3.1.0, npm/ansi-escapes@4.3.2, npm/any-promise@1.3.0, npm/at-least-node@1.0.0, npm/balanced-match@1.0.2, npm/bl@4.1.0, npm/buffer-alloc-unsafe@1.1.0, npm/buffer-alloc@1.2.0, npm/buffer-fill@1.0.0, npm/buffer-from@1.1.2, npm/clean-stack@2.2.0, npm/command-exists@1.2.9, npm/deep-extend@0.6.0, npm/doctrine@3.0.0, npm/escalade@3.1.1, npm/find-yarn-workspace-root@2.0.0, npm/globals@11.12.0, npm/gopd@1.0.1, npm/has-proto@1.0.1, npm/has-tostringtag@1.0.0, npm/indent-string@4.0.0, npm/invariant@2.2.4, npm/is-arguments@1.1.1, npm/is-date-object@1.0.5, npm/is-docker@2.2.1, npm/is-number@7.0.0, npm/is-plain-object@2.0.4, npm/is-regex@1.1.4, npm/is-unicode-supported@0.1.0, npm/is-wsl@2.2.0, npm/isobject@3.0.1, npm/js-tokens@4.0.0, npm/jsesc@2.5.2, npm/json-parse-better-errors@1.0.2, npm/lines-and-columns@1.2.4, npm/merge-stream@2.0.0, npm/nice-try@1.0.5, npm/node-forge@1.3.1, npm/object-is@1.1.5, npm/p-map@4.0.0, npm/p-try@2.2.0, npm/path-exists@4.0.0, npm/path-key@3.1.1, npm/path-parse@1.0.7, npm/picocolors@1.0.0, npm/progress@2.0.3, npm/pump@3.0.0, npm/regenerate@1.4.2, npm/require-main-filename@2.0.0, npm/reusify@1.0.4, npm/run-parallel@1.2.0, npm/shebang-regex@3.0.0, npm/signal-exit@3.0.7, npm/stacktrace-parser@0.1.10, npm/strip-final-newline@2.0.0, npm/supports-preserve-symlinks-flag@1.0.0, npm/thenify-all@1.6.0, npm/thenify@3.3.1, npm/to-regex-range@5.0.1, npm/y18n@5.0.8

View full report↗︎

@bmzig bmzig marked this pull request as ready for review January 9, 2025 18:59
@bmzig bmzig requested a review from dohaki January 9, 2025 18:59
@bmzig bmzig merged commit 3888d71 into master Jan 9, 2025
9 checks passed
@bmzig bmzig deleted the bz/lensTestnet branch January 9, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants