Skip to content

Conversation

@Reinis-FRP
Copy link
Contributor

OZ identified following issue:

The Accounts derive macro includes an attribute named Instruction that provides access to the instruction’s
arguments within the struct utilizing the macro. However, in the WriteInstructionParamsFragment struct, this
attribute is unnecessary, as neither the offset nor the fragment arguments are used within the struct.

This inclusion may lead to confusion for developers working on the codebase. As such, consider removing the
unused attribute to improve code clarity and maintainability.

This PR addresses the issue by removing the unused instruction attribute.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
@linear
Copy link

linear bot commented Jan 7, 2025

@Reinis-FRP Reinis-FRP merged commit 3b9b18a into master Jan 20, 2025
9 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis/acx-3595-n-06-unnecessary-use-of-instruction-attribute branch January 20, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants