Skip to content

Conversation

@md0x
Copy link
Contributor

@md0x md0x commented Jan 6, 2025

Changes proposed in this PR:
Fix the following issue identified by OZ:

The [transfer_ownership](https://github.com/across-protocol/contracts/blob/0f2600f83e8a5738d0d62a78b05ff37adda4c1c9/programs/svm-spoke/src/instructions/admin.rs#L110) function does not emit any relevant events after performing sensitive actions.

Consider emitting events after sensitive changes take place to facilitate off-chain tracking and monitoring.

md0x added 2 commits January 6, 2025 13:22
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x changed the title feat(svm): transfer ownership event feat(svm): L-07 transfer ownership event Jan 6, 2025
@md0x md0x marked this pull request as ready for review January 6, 2025 13:44
Comment on lines 11 to 14
event::{
EmergencyDeletedRootBundle, EnabledDepositRoute, PausedDeposits, PausedFills, RelayedRootBundle,
SetXDomainAdmin,
SetXDomainAdmin, TransferredOwnership,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is linted correctly, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@md0x md0x merged commit 84e5319 into master Jan 20, 2025
9 checks passed
@md0x md0x deleted the md0x/svm-l-07 branch January 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants