Skip to content

improve(tests): silence unsafeAllowDelegatecall warning in tests #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 7, 2025
Merged

improve(tests): silence unsafeAllowDelegatecall warning in tests #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6033a74
improve(tests): silence `unsafeAllowDelegatecall` warning in tests
bmzig Dec 23, 2024
7a9403d
bump package
bmzig Dec 23, 2024
787b917
silence tests only
bmzig Dec 31, 2024
a2cda09
lint
bmzig Dec 31, 2024
68ba809
revert changes
bmzig Dec 31, 2024
6121344
clean
bmzig Dec 31, 2024
516a37b
revert package bump
bmzig Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/evm/hardhat/fixtures/HubPool.Fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ export const hubPoolFixture = hre.deployments.createFixture(async ({ ethers }) =
return await deployHubPool(ethers);
});

// Silence warnings from openzeppelin/hardhat-upgrades for this fixture.
hre.upgrades.silenceWarnings();

export async function deployHubPool(ethers: any, spokePoolName = "MockSpokePool") {
const [signer, crossChainAdmin] = await ethers.getSigners();

Expand Down
3 changes: 3 additions & 0 deletions test/evm/hardhat/fixtures/SpokePool.Fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ export const spokePoolFixture = hre.deployments.createFixture(async ({ ethers })
return await deploySpokePool(ethers);
});

// Silence warnings from openzeppelin/hardhat-upgrades for this fixture.
hre.upgrades.silenceWarnings();

// Have a separate function that deploys the contract and returns the contract addresses. This is called by the fixture
// to have standard fixture features. It is also exported as a function to enable non-snapshoted deployments.
export async function deploySpokePool(
Expand Down
Loading