feat(svm): query events script #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
md0x
force-pushed
the
pablo/query-events-script
branch
from
70c4631 to
423dcaa
Compare
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
chrismaree
approved these changes
Dec 17, 2024
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Reinis-FRP
reviewed
Dec 17, 2024
| type: "string", | ||
| demandOption: false, | ||
| describe: "Name of the event to query", | ||
| choices: [ |
There was a problem hiding this comment.
nit: shouldn't event names start with capital letter?
There was a problem hiding this comment.
The EventCoder returns them with the first letter in lowercase. I guess we could capitalize the events ourselves in the processEventFromTx function as a custom treatment, but we aren’t doing that. That’s why the event names should match those returned by the EventCoder.
Reinis-FRP
reviewed
Dec 17, 2024
src/svm/solanaProgramUtils.ts
Outdated
| */ | ||
| export function stringifyCpiEvent(obj: any): any { | ||
| if (obj?.constructor?.toString()?.includes("PublicKey")) { | ||
| if (obj.toString().includes("111111111111")) { |
There was a problem hiding this comment.
unlikely to have zeroes anywhere else than in the beginning, though, still better to restrict that only the first 12 bytes matching 0 are translated as EVM addresses
Reinis-FRP
reviewed
Dec 17, 2024
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: