feat: improve event utils #789
Conversation
…ve-event-utils' of github.com:across-protocol/contracts into chrismaree/improve-event-utils
| return events; | ||
|
|
||
| // Fetch events for all signatures in parallel | ||
| const eventsWithSlots = await Promise.all( |
There was a problem hiding this comment.
This could be resource intensive if there are many signatures. Should we consider batching the Promise.all calls with a configurable batch size to improve efficiency?
There was a problem hiding this comment.
same net efficiency, right? it's the same number of requests. the bigger issue could be the RPC provider blocking this or having an issue with the number of requests but for now we can leave it like this and improve when we get there.
There was a problem hiding this comment.
Yeah, I meant splitting in chunks and run them sequentially. Similarly to how we do it here:
https://github.com/UMAprotocol/protocol/blob/e526e5a1caf68ae7be706f6ef9c996660429282a/packages/common/src/EventUtils.ts#L36-L38
But it's ok for now I think!
simple PR to improve the events utils used on SVM. measurably improves performance and enables us to handle more than 1000 event limt.