fix: scripts to rebalance funds from hub to spoke #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Reinis-FRP
changed the title
chrismaree
reviewed
Dec 4, 2024
Comment on lines
+170
to
+177
| .getNoncePda({ | ||
| nonce: new BN(nonce.toString()), | ||
| sourceDomain: remoteDomain, | ||
| }) | ||
| .accounts({ | ||
| messageTransmitter: messageTransmitterState, | ||
| }) | ||
| .view()) as PublicKey; |
chrismaree
reviewed
Dec 4, 2024
Comment on lines
+190
to
+239
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: tokenMessengerAccount, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: remoteTokenMessengerKey, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: true, | ||
| pubkey: tokenMinterAccount, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: true, | ||
| pubkey: localToken, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: tokenPair, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: true, | ||
| pubkey: vault, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: true, | ||
| pubkey: custodyTokenAccount, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: TOKEN_PROGRAM_ID, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: tokenMessengerEventAuthority, | ||
| }); | ||
| remainingAccounts.push({ | ||
| isSigner: false, | ||
| isWritable: false, | ||
| pubkey: tokenMessengerMinterProgram.programId, | ||
| }); |
There was a problem hiding this comment.
same with this. I think it can be linted to be much shorter.
md0x
reviewed
Dec 4, 2024
| @@ -0,0 +1,293 @@ | |||
| // This script executes root bundle on HubPool that rebalances tokens to Solana Spoke Pool. Required environment: | |||
| // - ETHERS_PROVIDER_URL: Ethereum RPC provider URL. | |||
There was a problem hiding this comment.
As part of the tech debt task we can update this env vars to be consistent across the scripts so this comment is just an observation
md0x
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good.
There might be some changes to improve environment variable consistency with other scripts, move some hardcoded values to the constants file, and relocate some reused functions to a common library as well. However, that can be part of the tech debt task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scripts that allows to test pool rebalancing from HubPool to Solana SpokePool. Tested in these tx: