feat: update scripts #776
feat: update scripts #776
Conversation
…l/contracts into chrismaree/update-scripts
|
|
||
| [provider] | ||
| cluster = "localnet" | ||
| wallet = "test/svm/keys/localnet-wallet.json" |
There was a problem hiding this comment.
this would break forking tests where we have overrided CCTP state with this key as permissioned actor
There was a problem hiding this comment.
yes, was not planning on committing when the PR is ready
scripts/svm/simpleFill.ts
Outdated
| const outputAmount = new BN(resolvedArgv.outputAmount); | ||
| const originChainId = new BN(resolvedArgv.originChainId); | ||
| const depositId = resolvedArgv.depositId; | ||
| const depositId = intToU8Array32(resolvedArgv.depositId); |
There was a problem hiding this comment.
this might not work with deterministic ids because of JS number size limitations. maybe better let resolvedArgv.depositId be string and parse it as BigNum->U8Array32 if it starts with 0x?
There was a problem hiding this comment.
ye, this is a good point. I've updated accordingly and updated intToU8Array32 to support BN.
| const outputAmount = new BN(resolvedArgv.outputAmount); | ||
| const originChainId = new BN(resolvedArgv.originChainId); | ||
| const depositId = intToU8Array32(resolvedArgv.depositId); | ||
| const depositId = intToU8Array32(new BN(resolvedArgv.depositId)); |
There was a problem hiding this comment.
I don't think BN constructor automatically detects and parses hex strings
There was a problem hiding this comment.
it's assumed its just a large number in a string so should be fine.
| describe: "Ethereum address to convert", | ||
| }).argv; | ||
|
|
||
| async function logPublicKey(): Promise<void> { |
There was a problem hiding this comment.
Do we want to add this to Anchor.toml scripts?
There was a problem hiding this comment.
can run it with node as well but I'll add it, sure.
After playing with scripts last week, a number of the scripts were broken due to recent changes pre-audit.
This PR fixes this.