Skip to content

Conversation

@chrismaree
Copy link
Member

@chrismaree chrismaree commented Nov 25, 2024

PR to further refine some comments and lining nits.

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@socket-security
Copy link

socket-security bot commented Nov 25, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
fill_status_account.relayer = *ctx.accounts.signer.key;

if relay_data.message.len() > 0 {
if !relay_data.message.is_empty() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
}

#[event]
pub struct EmergencyDeleteRootBundle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we rename this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did it in #774.

I need to re-base & it'll be up to date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Copy link
Contributor

@Reinis-FRP Reinis-FRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@socket-security
Copy link

socket-security bot commented Nov 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nodelib/fs.scandir@2.1.5 filesystem 0 22.2 kB mrmlnc
npm/aggregate-error@3.1.0 None 0 6.69 kB sindresorhus
npm/any-promise@1.3.0 None 0 22.2 kB kevinbeaty
npm/balanced-match@1.0.2 None 0 6.94 kB juliangruber
npm/callsites@3.1.0 None 0 6.33 kB sindresorhus
npm/ci-info@2.0.0 environment 0 12.8 kB watson
npm/clean-stack@2.2.0 None 0 5.51 kB sindresorhus
npm/cliui@7.0.4 None 0 30.6 kB oss-bot
npm/deep-extend@0.6.0 None 0 9.19 kB unclechu
npm/define-data-property@1.1.4 None 0 30.9 kB ljharb
npm/detect-libc@2.0.2 filesystem, shell 0 23.7 kB lovell
npm/env-paths@2.2.1 None 0 10.2 kB sindresorhus
npm/err-code@2.0.3 None 0 12.3 kB achingbrain
npm/es-define-property@1.0.0 None 0 11.8 kB ljharb
npm/es-errors@1.3.0 None 0 12.3 kB ljharb
npm/events@3.3.0 None 0 82.8 kB goto-bus-stop
npm/for-each@0.3.3 None 0 13 kB ljharb
npm/globalthis@1.0.3 None 0 22.4 kB ljharb
npm/gopd@1.0.1 None 0 7.7 kB ljharb
npm/has-property-descriptors@1.0.2 None 0 10.9 kB ljharb
npm/http-cache-semantics@4.1.1 None 0 35.9 kB kornel
npm/import-fresh@3.3.0 Transitive: filesystem, unsafe +1 9.51 kB sindresorhus
npm/indent-string@4.0.0 None 0 4.4 kB sindresorhus
npm/is-docker@2.2.1 filesystem 0 3.01 kB sindresorhus
npm/is-string@1.0.7 None 0 19.1 kB ljharb
npm/is-wsl@2.2.0 environment, filesystem 0 3.76 kB sindresorhus
npm/json-parse-better-errors@1.0.2 None 0 6.7 kB zkat
npm/json-parse-even-better-errors@2.3.1 None 0 10.4 kB isaacs
npm/lines-and-columns@1.2.4 None 0 5.39 kB eventualbuddha
npm/merge-stream@2.0.0 None 0 4.31 kB stevemao
npm/mimic-fn@2.1.0 None 0 4.46 kB sindresorhus
npm/mz@2.7.0 filesystem, network, shell 0 9.77 kB jongleberry
npm/onetime@5.1.2 None 0 6.17 kB sindresorhus
npm/p-map@4.0.0 None 0 8.69 kB sindresorhus
npm/parse5@6.0.1 None 0 331 kB inikulin
npm/path-exists@4.0.0 filesystem 0 3.92 kB sindresorhus
npm/path-key@3.1.1 None 0 4.55 kB sindresorhus
npm/path-parse@1.0.7 None 0 4.51 kB jbgutierrez
npm/picocolors@1.0.0 environment 0 5.66 kB alexeyraspopov
npm/proxy-from-env@1.1.0 environment 0 29.5 kB rob-w
npm/repeat-string@1.6.1 None 0 9.09 kB jonschlinkert
npm/reusify@1.0.4 None 0 9.44 kB matteo.collina
npm/run-parallel@1.2.0 None 0 6.56 kB feross
npm/shebang-command@2.0.0 None 0 2.56 kB kevva
npm/shebang-regex@3.0.0 None 0 2.83 kB sindresorhus
npm/signal-exit@3.0.7 None 0 9.96 kB isaacs
npm/spdx-expression-parse@3.0.1 None 0 11.8 kB kemitchell
npm/split2@4.2.0 None 0 17.4 kB matteo.collina
npm/strip-final-newline@2.0.0 None 0 3.05 kB sindresorhus
npm/thenify-all@1.6.0 None 0 6.59 kB dead_horse
npm/thenify@3.3.1 None 0 7.92 kB dead_horse
npm/type-fest@0.20.2 None 0 111 kB sindresorhus
npm/validate-npm-package-license@3.0.4 None 0 16.6 kB kemitchell
npm/wrap-ansi@7.0.0 None 0 10.6 kB sindresorhus
npm/y18n@5.0.8 filesystem 0 23.4 kB oss-bot

🚮 Removed packages: npm/@sindresorhus/is@0.14.0, npm/@szmarczak/http-timer@1.1.2, npm/@types/minimatch@3.0.5, npm/@ungap/promise-all-settled@1.1.2, npm/any-signal@2.1.2, npm/argparse@1.0.10, npm/binary-extensions@2.2.0, npm/bip66@1.1.5, npm/browser-stdout@1.3.1, npm/bytes@3.1.2, npm/cacheable-request@6.1.0, npm/call-bind@1.0.2, npm/color@3.2.1, npm/crypto-browserify@3.12.0, npm/decompress-response@3.3.0, npm/delayed-stream@1.0.0, npm/destroy@1.2.0, npm/drbg.js@1.0.1, npm/duplexer3@0.1.4, npm/ee-first@1.1.1, npm/esutils@2.0.3, npm/eth-lib@0.1.29, npm/fill-range@7.0.1, npm/find-up@3.0.0, npm/fs.realpath@1.0.0, npm/get-intrinsic@1.1.1, npm/get-stream@4.1.0, npm/global@4.4.0, npm/growl@1.10.5, npm/he@1.2.0, npm/http-response-object@3.0.2, npm/iconv-lite@0.4.24, npm/inflight@1.0.6, npm/ipfs-core-types@0.3.1, npm/ipfs-core-utils@0.7.2, npm/ipfs-utils@6.0.8, npm/ipld-block@0.11.1, npm/ipld-dag-cbor@0.17.1, npm/ipld-dag-pb@0.20.0, npm/ipld-raw@6.0.0, npm/is-extglob@2.1.1, npm/is-function@1.0.2, npm/is-hex-prefixed@1.0.0, npm/is-typedarray@1.0.0, npm/isexe@2.0.0, npm/isstream@0.1.2, npm/it-last@1.0.6, npm/it-map@1.0.6, npm/it-tar@1.2.2, npm/it-to-stream@0.1.2, npm/kind-of@6.0.3, npm/log-symbols@3.0.0, npm/media-typer@0.3.0, npm/merge-options@3.0.4, npm/micromatch@4.0.4, npm/mkdirp-promise@5.0.1, npm/mock-fs@4.14.0, npm/multiaddr@8.1.2, npm/native-abort-controller@1.0.4, npm/negotiator@0.6.3, npm/node-environment-flags@1.0.6, npm/oauth-sign@0.9.0, npm/object-assign@4.1.1, npm/object-inspect@1.12.0, npm/object.assign@4.1.0, npm/optionator@0.8.3, npm/p-cancelable@1.1.0, npm/parse-duration@0.4.4, npm/parse-headers@2.0.4, npm/path-is-absolute@1.0.1, npm/performance-now@2.1.0, npm/req-from@2.0.0, npm/request-promise-core@1.1.4, npm/source-map@0.2.0, npm/stealthy-require@1.1.1, npm/stream-to-it@0.2.4, npm/strip-json-comments@2.0.1, npm/sync-rpc@1.3.6, npm/tar@4.4.19, npm/text-hex@1.0.0, npm/then-request@6.0.2, npm/to-readable-stream@1.0.0, npm/toidentifier@1.0.1, npm/tough-cookie@2.5.0, npm/tunnel-agent@0.6.0, npm/uint8arrays@2.1.10, npm/url-parse-lax@3.0.0, npm/util@0.12.4, npm/web3-providers-http@1.7.0, npm/web3-providers-ipc@1.7.0, npm/web3-providers-ws@1.7.0, npm/wide-align@1.1.3, npm/wrappy@1.0.2, npm/xhr-request@1.1.0, npm/yargs-parser@13.1.2, npm/yargs-unparser@1.6.0

View full report↗︎

Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree chrismaree merged commit ea2780e into master Nov 25, 2024
7 of 9 checks passed
@chrismaree chrismaree deleted the chrismaree/further-comment-nits branch November 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants