fix(svm): use borch serializer #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
md0x
reviewed
Nov 22, 2024
| for address in &self.refund_addresses { | ||
| bytes.extend_from_slice(address.as_ref()); | ||
| } | ||
| AnchorSerialize::serialize(&self, &mut bytes)?; |
md0x
reviewed
Nov 22, 2024
| .remainingAccounts(fillRemainingAccounts) | ||
| .rpc(); | ||
| .instruction(); | ||
| const computeBudgetInstruction = ComputeBudgetProgram.setComputeUnitLimit({ units: 1_400_000 }); |
There was a problem hiding this comment.
Has the borsh serialisation increased the CU?
There was a problem hiding this comment.
Its hard to tell precisely as our tests are not deterministic and have much more variance due to differing bumps in PDA derivation, but over 10 runs I observed on average +2% in CU, which I guess is acceptable here.
md0x
reviewed
Nov 22, 2024
|
|
||
| const refundAddressesBuffer = Buffer.concat(relayData.refundAddresses.map((address) => address.toBuffer())); | ||
|
|
||
| // TODO: We better consider reusing Borch serializer in production. |
There was a problem hiding this comment.
+1 we should probably test this and make sure they produce the same byte layout
md0x
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had custom serialization implementation when hashing relayer refund and slow fill leaves. This just concatenated array elements without encoding array length. This PR fixes by using Anchor's borch serializer that encodes this more consistently.