feat: handle EIP-2612 and EIP-3009 in SwapAndBridge.sol
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
commented
Nov 18, 2024
nicholaspai
reviewed
Nov 18, 2024
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
reviewed
Nov 18, 2024
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nicholaspai
reviewed
Nov 18, 2024
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
reviewed
Nov 19, 2024
nicholaspai
approved these changes
Nov 19, 2024
Signed-off-by: bennett <bennett@umaproject.org>
mrice32
reviewed
Nov 19, 2024
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
reviewed
Nov 20, 2024
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
reviewed
Nov 21, 2024
Signed-off-by: bennett <bennett@umaproject.org>
pxrl
reviewed
Nov 21, 2024
pxrl
reviewed
Nov 21, 2024
pxrl
reviewed
Nov 21, 2024
mrice32
added a commit
that referenced
this pull request
Feb 3, 2025
…)" This reverts commit fa67f5e.
mrice32
added a commit
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to have a way to deposit into the spoke pool and perform a
swapAndBridgeusing EIP-2612 and EIP-3009.This functionality is added with four new functions in the
UniversalSwapAndBridgecontract:swapAndBridgeWithPermit,depositWithPermit,swapAndBridgeWithAuthorization, anddepositWithAuthorization, where*WithPermitindicates usage of an EIP-2612 compliant token, and*WithAuthorizationindicates usage of an EIP-3009 compliant token.Details
EIP-2616 is used solely to give an approval to an address without calling
approvefirst. This allows us to still usetransferFromwhen using any EIP-2612 token.On the other hand, EIP-3009 will simply transfer tokens to the designated receiver contract and not raise the contract's allowance, so all usage of these types of functions check whether a sufficient token amount was transferred to the contract before proceeding with the rest of the swap/deposit.