improve: use immutable SHARED_BRIDGE whenever possible
#748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
approved these changes
Nov 14, 2024
|
Is this an audit related issue? Do we need to change the PR title? |
It isn't addressing the issue outlined in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ZkStack_*_Adapter, we assume that the bridge hub's shared bridge is immutable. While this is not true -- the shared bridge may be changed in the future -- it is assumed to be immutable so that L1 calls will be cheaper, as we stand to save ~2staticcalls per message. The hope is in the long run, if these bridges change, the cost of redeploying an adapter will have already been "paid off" by the gas savings of assuming immutability.