fix(svm): use consistent imports #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Reinis-FRP
commented
Oct 16, 2024
| pub struct Initialize<'info> { | ||
| #[account(init, // Use init, not init_if_needed to prevent re-initialization. | ||
| payer = signer, | ||
| space = DISCRIMINATOR_SIZE + State::INIT_SPACE, // TODO: check that INIT_SPACE is used everywhere |
There was a problem hiding this comment.
checked this, no changes needed, so removed the comment just to avoid separate PR for that.
Reinis-FRP
commented
Oct 16, 2024
| use anchor_spl::associated_token::AssociatedToken; | ||
| use anchor_spl::token_interface::{Mint, TokenAccount, TokenInterface}; | ||
|
|
||
| // TODO: check that the discriminator size is used everywhere |
There was a problem hiding this comment.
checked this, no changes needed, so removed the comment just to avoid separate PR for that.
chrismaree
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes to standardize formatting of Solana program imports grouping them in 3 blocks separated by newline:
Also avoids replicated use statements and has nested grouping when imports share the same root.
Fixes: https://linear.app/uma/issue/ACX-2911/instructionsadminrs-standardize-imports-across-all-files