Skip to content

Conversation

@bmzig
Copy link
Contributor

@bmzig bmzig commented Sep 26, 2024

To reduce the diff of #609

Signed-off-by: bennett <bennett@umaproject.org>
* - The token must have a max of 2^256 - 1 wei total supply unscaled
* - The token must have a max of 2^256 - 1 wei total supply when scaled to 18 decimals
*/
interface ArbitrumERC20Bridge {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i don't think this file should end with "Interfaces" if its in an /interfaces path. Maybe rename to ArbitrumBridge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here 1da1449

Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment then LGTM

Signed-off-by: bennett <bennett@umaproject.org>
@bmzig bmzig merged commit a2afefe into master Sep 27, 2024
9 checks passed
@bmzig bmzig deleted the bz/refactorArbInterfaces branch September 27, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants