Skip to content

feat(svm-routes): add additional param to block non-enabled routes #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2024
Merged

feat(svm-routes): add additional param to block non-enabled routes #619

merged 4 commits into from
Sep 24, 2024

Conversation

@md0x
Copy link
Contributor

@md0x md0x commented Sep 23, 2024 •
edited
Loading

Changes proposed in this PR:

  • Fix routes seed to use state key to prevent passing fake enabled routes

md0x added 2 commits September 23, 2024 13:25
@md0x
test: fake route test
df47a3e 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x
feat: fix fake route issue with state key in route seed
cfdc835 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x marked this pull request as ready for review September 23, 2024 15:27
@md0x
feat: remove todo
ad0c1f9 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
Reinis-FRP
Reinis-FRP approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Reinis-FRP Reinis-FRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

chrismaree
chrismaree approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@chrismaree chrismaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! really good check.

there might be other kinds of derivation issue we have as a result of not using the state within parts of the PDA key seed...we should explore every bit of state to ensure they are sufficiently locked like this.

@md0x md0x changed the title test: fake route test feat(svm-routes): add additional param to block non-enabled routes Sep 24, 2024
@md0x md0x merged commit 42f8398 into master Sep 24, 2024
9 checks passed
@md0x md0x deleted the pablo/fake-route branch September 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrismaree chrismaree chrismaree approved these changes

@Reinis-FRP Reinis-FRP Reinis-FRP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@md0x @chrismaree @Reinis-FRP