Skip to content

Conversation

@chrismaree
Copy link
Member

@chrismaree chrismaree commented Sep 18, 2024

this PR brings over the initial SVM implementation for the spoke pool.

two worthy callouts:

  1. the svm ts is not yet type safe and failed on ts build. it's ignored for now
  2. the svm build process is a bit janky (see the comment in this PR) and will be improved soon.

Signed-off-by: chrismaree <christopher.maree@gmail.com>
@socket-security
Copy link

socket-security bot commented Sep 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
"clean": "rm -rf node_modules cache cache-zk artifacts artifacts-zk dist typechain",
"build": "hardhat compile && anchor build && tsc && rsync -a --include '*/' --include '*.d.ts' --exclude '*' ./typechain ./dist/",
"build-evm": "hardhat compile",
"build-svm": "echo 'Generating IDLs...' && anchor build > /dev/null 2>&1 || true && anchor run generateExternalTypes && anchor build",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this build-svm command right now is super hacky. in order for anchor build to run correctly first time we require that first anchor run generateEternalTypes is run. however, this second command requires the IDLs and types to be generated, which are first built from anchor build. i.e we run the build command, which generates the IDLs and types, but then fails to build, which is then used in the generateExternalTypes command, which is then used again in the anchor build.

we will improve this in a follow on PR but for now it works as expected, despite being a bit round about.

"tasks/enableL1TokenAcrossEcosystem.ts",
"utils/utils.ts"
],
"exclude": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new ts associated with sim stuff is not yet totally type safe! we are simply ignoring this for now and will improve it soon

@chrismaree chrismaree marked this pull request as ready for review September 19, 2024 03:04
chrismaree and others added 4 commits September 20, 2024 10:23
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
@socket-security
Copy link

socket-security bot commented Sep 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@solana-developers/helpers@2.5.5 None 0 93.5 kB mikemaccana
npm/@solana/buffer-layout-utils@0.2.0 None 0 39.6 kB jordansexton
npm/@solana/codecs-core@2.0.0-rc.1 None 0 496 kB lorisleiva
npm/@solana/codecs-data-structures@2.0.0-rc.1 None 0 756 kB lorisleiva
npm/@solana/codecs-numbers@2.0.0-rc.1 None 0 246 kB lorisleiva
npm/@solana/codecs-strings@2.0.0-rc.1 None 0 208 kB lorisleiva
npm/@solana/codecs@2.0.0-rc.1 None 0 18.6 kB lorisleiva
npm/@solana/errors@2.0.0-rc.1 None 0 1.34 MB lorisleiva
npm/@solana/options@2.0.0-rc.1 None 0 147 kB lorisleiva
npm/@solana/spl-token-group@0.0.5 None 0 64.3 kB buffalojoec
npm/@solana/spl-token-metadata@0.1.5 None 0 72.2 kB buffalojoec
npm/@solana/spl-token@0.4.8 None 0 1.75 MB buffalojoec
npm/@solana/spl-type-length-value@0.1.0 None 0 39.7 kB buffalojoec
npm/@types/bn.js@5.1.0 None 0 13.9 kB types
npm/ansi-styles@4.3.0 None 0 17 kB sindresorhus
npm/bignumber.js@9.0.2 None 0 349 kB mikemcl
npm/bs58@6.0.0 None 0 5.14 kB junderw
npm/chalk@5.3.0 None 0 43.7 kB sindresorhus
npm/color-name@1.1.4 None 0 6.69 kB dfcreative
npm/escape-string-regexp@2.0.0 None 0 3.26 kB sindresorhus
npm/supports-color@6.0.0 None 0 7.26 kB sindresorhus
npm/yargs@17.7.2 environment, filesystem 0 292 kB oss-bot

🚮 Removed packages: npm/@consensys/linea-sdk@0.1.6, npm/@enzoferey/ethers-error-parser@0.2.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@types/bn.js@4.11.6, npm/ansi-styles@3.2.1, npm/better-sqlite3@8.7.0, npm/bignumber.js@7.2.1, npm/bs58@4.0.1, npm/chalk@2.4.2, npm/class-validator@0.14.0, npm/color-name@1.1.3, npm/escape-string-regexp@1.0.5, npm/is-bigint@1.0.4, npm/is-boolean-object@1.1.2, npm/is-number-object@1.0.6, npm/js-tokens@4.0.0, npm/proxy-from-env@1.1.0, npm/supports-color@5.5.0, npm/yargs@16.2.0, npm/zksync-web3@0.14.3

View full report↗︎

chrismaree and others added 9 commits September 20, 2024 10:24
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
@Reinis-FRP Reinis-FRP merged commit 9f48b42 into master Sep 20, 2024
9 checks passed
@Reinis-FRP Reinis-FRP deleted the chrismaree/move-over-svm-spokepool-mvp branch September 20, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants