Skip to content

refactor: Deployment script cleanup #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 22, 2024
Merged

refactor: Deployment script cleanup #561

merged 19 commits into from
Aug 22, 2024

Conversation

@pxrl
Copy link
Contributor

@pxrl pxrl commented Jul 16, 2024 •
edited
Loading

  • Replace numeric chain IDs with symbolic IDs.
  • Define constants for quote timestamp buffer and fill deadline buffer.
  • Defer to upstream-defined token addresses.
  • General minor refactoring to shrink code.

@pxrl
refactor(deploy): Use external constants
ba85289 
- Replace numeric chain IDs with symbolic IDs.
- Defer to upstream-defined tokena addresses.
- Remove pre-Sepolia testnet definitions.
pxrl added 3 commits July 17, 2024 00:45
@pxrl
Drop legacy chains from deployments
4bc6d30
@pxrl
fix
74a0810
@pxrl
lint
9aa6d2e 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
dohaki
dohaki approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

james-a-morris
james-a-morris reviewed Jul 18, 2024
View reviewed changes
pxrl
pxrl commented Aug 9, 2024
View reviewed changes
pxrl added 6 commits August 9, 2024 23:21
@pxrl
Drop implementation-only flag
80b026d
@pxrl
Merge remote-tracking branch 'origin/master' into pxrl/extern
47a9747
@pxrl
Revert merge
25cdd4e
@pxrl
More consolidation
11241d7 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl
Cleanup
856c6f1 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl
More constants
80f629b 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
pxrl
pxrl commented Aug 9, 2024
View reviewed changes
@pxrl
More cleanup
4535d32 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
pxrl added 2 commits August 10, 2024 00:29
@pxrl
lint
6891052 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl
Simplify
05ec19d 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl pxrl requested a review from nicholaspai August 9, 2024 22:53
@pxrl
lint
222b3e2 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl pxrl changed the title refactor(deploy): Use external constants refactor: Deployment script cleanup Aug 9, 2024
@pxrl
liiiiiint,
57db20b 
Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com>
@pxrl pxrl requested a review from mrice32 August 12, 2024 14:37
@nicholaspai nicholaspai merged commit e8e77b7 into master Aug 22, 2024
@nicholaspai nicholaspai deleted the pxrl/extern branch August 22, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@dohaki dohaki dohaki approved these changes

@bmzig bmzig bmzig approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

+1 more reviewer

@james-a-morris james-a-morris james-a-morris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pxrl @nicholaspai @dohaki @bmzig @james-a-morris