feat: Add storage layout check script to ci #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple script that errors if developer makes changes that would change the storage layout but hasn't committed new storage layout file
nicholaspai
changed the title
nicholaspai
requested review from
amateima,
dohaki,
james-a-morris,
mrice32 and
pxrl
nicholaspai
force-pushed
the
npai/check-storage-layout
branch
from
a168e0f to
54b2ddd
Compare
mrice32
approved these changes
Mar 20, 2024
rkokhatskyi
reviewed
Mar 25, 2024
Comment on lines
+45
to
+47
| strategy: | ||
| matrix: | ||
| node: [16] |
There was a problem hiding this comment.
Is there a need to use matrix? Looks like it is only one param to use (not sure if you guys are planning to run with other nodes too). By the way node 16 is no longer maintained and considered deprecated https://nodejs.org/en/blog/announcements/nodejs16-eol
There was a problem hiding this comment.
yeah we need to move off of this but our stack currently can't automatically upgrade. @james-a-morris is working on this
Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple script that errors if developer makes changes that would change the storage layout but hasn't committed new storage layout file