feat: Deploy new SpokePool implementations #461
Conversation
nicholaspai
commented
Mar 1, 2024
nicholaspai
commented
- ZkSync: https://explorer.zksync.io/address/0x0DA0a157D40B3348285F1a88a329c9387e51bCF9#contract
- Polygon: https://polygonscan.com/address/0x9f444346FD853084158ce9cfa7e062BaBd51a577#code
- Optimism: https://optimistic.etherscan.io/address/0x5226a5D010F24F0df089963E94ce88E4c87EB53b#code
- Base: https://basescan.org/address/0x053Dc4a08302F11d13d8D2B87D8F3c9c28cEDEb4#code
- Arbitrum: https://arbiscan.io/address/0x53dcC21887d54f41B049724b73a2195CE7343873#code
- Ethereum: https://etherscan.io/address/0xa4D3535f33549749Fb97fA42903AC80F6fb54af6#code
This PR showcases how we will remove all non-USS functionality in the spoke pools once all non-USS deposits are fills, fills are refunded, and roots are executed. This PR reduces the bytecode significantly and means we can use the full optimizer runs setting for compiling these new contracts
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
This PR implements a simple find-and-replace of "USS" with "V3" to make it more clear that this is a new version of the Across protocol that supports new features such as cross-chain token-swaps. USS is an internal code name for "Universal Settlement Service" but this is not neccessariy the language that will be used to market this product. So, renaming to V3 makes these contract changes more of a blank slate.
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
- ZkSync: https://explorer.zksync.io/address/0x0DA0a157D40B3348285F1a88a329c9387e51bCF9#contract - Polygon: https://polygonscan.com/address/0x9f444346FD853084158ce9cfa7e062BaBd51a577#code - Optimism: https://optimistic.etherscan.io/address/0x5226a5D010F24F0df089963E94ce88E4c87EB53b#code - Base: https://basescan.org/address/0x053Dc4a08302F11d13d8D2B87D8F3c9c28cEDEb4#code - Arbitrum: https://arbiscan.io/address/0x53dcC21887d54f41B049724b73a2195CE7343873#code - Ethereum: https://etherscan.io/address/0xa4D3535f33549749Fb97fA42903AC80F6fb54af6#code
|
@nicholaspai Do you plan to update Aside from that...this is all autogenerated, but do you think there are any specific checks we should make as part of reviewing this change? |
Nope, AFAIK the deployments.json only lists the proxy contracts or the SpokePool addresses that any client would be interfacing with |
I think checking the forge layouts is important, i can publish those as part of this PR? Finally, I think just double checking the new SpokePool changes we committed in 666bccb and that we are now deploying in this PR is paramount |
|
Consider re-deploying after removing |
Yeah, good point - no need to update deployments.json 👍 |
There was a problem hiding this comment.
Looks good! +1 on the new storage layouts in the diff -- very helpful to take a pass on those before deploying.
If the removal of depositFor was not removed in the audited version, I would suggest we leave it.
I'm assuming it's not causing bytecode issues or anything, right?
nope! |
