fix: remove hardhat from standard import #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
nicholaspai
approved these changes
Feb 29, 2024
james-a-morris
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
+1 Thoughts on deploying three packages to NPM?
- @across-protocol/contracts-v2/contracts (just contracts + typechain)
- @across-protocol/contracts-v2/test-suite (just the utils that need hardhat)
- @across-protocol/contracts-v2 (amalgam of 1 & 2)
We'd mostly import (1) but 2 could be useful as a dev resource.
pxrl
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove hardhat from the standard import path. This means that ts/js code that does:
will not need a hardhat config and will not spin up a local hardhat node by default. I've verified that the files in utils don't seem to be used in sdk-v2 or relayer-v2.
I think this was accidentally moved into our production exports in a larger change: #272.