feat: Add foundry.toml to support forge commands on repo
#407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "base64-sol/=node_modules/base64-sol/", | ||
| "eth-gas-reporter/=node_modules/eth-gas-reporter/", | ||
| "hardhat-deploy/=node_modules/hardhat-deploy/", | ||
| "hardhat/=node_modules/hardhat/", |
There was a problem hiding this comment.
We may need to add the mappings for the @scroll/tech contracts.
It's an NPM package
…405) We are missing a unit test that ensures that the _verifyUSSDepositorSignature correctly implements EIP1271 signing
…rotocol/contracts-v2 into mrice32/minimal_foundry
mrice32
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
forgein many ways, and the immediate way I think this could help is to snapshot and compare storage layouts to validate safe upgrades