feat: Add _distributeRelayerRefund unit tests #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
commented
Jan 4, 2024
| address[] memory refundAddresses, | ||
| uint256[] memory refundAmounts | ||
| ) internal view { | ||
| if (_chainId != chainId()) revert InvalidChainId(); |
There was a problem hiding this comment.
I moved these two checks so that they're closer to the logic that uses the variables checked
mrice32
approved these changes
Jan 4, 2024
| address[] memory refundAddresses, | ||
| uint256[] memory refundAmounts | ||
| ) internal view { | ||
| if (_chainId != chainId()) revert InvalidChainId(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors the SpokePool.sol code so that the validation of merkle leaf properties are done as close to their usage within the logic as possible