improve: Unit tests for _fillRelayUSS() internal logic and fillRelayUSS() external function #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function handles most of the fill logic and this PR adds useful test infrastructure for future testing
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
nicholaspai
changed the title
mrice32
approved these changes
Jan 2, 2024
| ] | ||
| ); | ||
| }); | ||
| it("fast fill emits correct FillType", async function () { |
There was a problem hiding this comment.
Just so I understand, does this fast fill replace the slow fill? Or is this a fresh fill?
If it's fresh, it would be good to add a test to be sure that we can overwrite the slow fill enum with a filled enum.
There was a problem hiding this comment.
A fast fill can replace a slow fill request or be a fresh fill. there is a specific test for this on line 400: "fast fill replacing speed up request emits correct FillType", PTAL!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal
_fillRelayUSSfunction handles most of the fill logic and this PR adds useful test infrastructure for future testing.This PR also includes unit testing logic specific to the external
fillUSSRelayfunction