Skip to content

Conversation

@nicholaspai
Copy link
Member

We should move the deployed tag to whichever contract version we end up deploying

We should move the `deployed` tag to whichever contract version we end up deploying
@nicholaspai nicholaspai requested review from mrice32 and pxrl November 13, 2023 14:58
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By deployed do you mean a git tag that gets updated each time we make a new deployment? If so, does that work in the case that we add a new chain? Then we'd be marking deployed against the entire state of the repository, but there might have been some minor adjustments to other contracts that were not re-deployed afterwards.

@nicholaspai
Copy link
Member Author

By deployed do you mean a git tag that gets updated each time we make a new deployment? If so, does that work in the case that we add a new chain? Then we'd be marking deployed against the entire state of the repository, but there might have been some minor adjustments to other contracts that were not re-deployed afterwards.

I think we should move up the deployed git tag whenever we want to signal that the latest code in contracts match deployed addresses. This unfortunately doesn't handle the case well where SpokePool implementations differ between chains...TBH I'm not sure yet how to handle that. We could maintain a mapping of chain ID --> git commit hash but this is better than what we currently have where one's best guess is that master matches deployed but that's not true pretty frequently

@nicholaspai nicholaspai requested a review from pxrl November 13, 2023 18:42
@pxrl
Copy link
Contributor

pxrl commented Nov 14, 2023

By deployed do you mean a git tag that gets updated each time we make a new deployment? If so, does that work in the case that we add a new chain? Then we'd be marking deployed against the entire state of the repository, but there might have been some minor adjustments to other contracts that were not re-deployed afterwards.

I think we should move up the deployed git tag whenever we want to signal that the latest code in contracts match deployed addresses. This unfortunately doesn't handle the case well where SpokePool implementations differ between chains...TBH I'm not sure yet how to handle that. We could maintain a mapping of chain ID --> git commit hash but this is better than what we currently have where one's best guess is that master matches deployed but that's not true pretty frequently

How about having a tag for each contract that gets updated when it's (re)deployed? For example spokepool-arbitrum-deployed. It implies a little bit of management, but we don't deploy all that often.

Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicholaspai
Copy link
Member Author

By deployed do you mean a git tag that gets updated each time we make a new deployment? If so, does that work in the case that we add a new chain? Then we'd be marking deployed against the entire state of the repository, but there might have been some minor adjustments to other contracts that were not re-deployed afterwards.

I think we should move up the deployed git tag whenever we want to signal that the latest code in contracts match deployed addresses. This unfortunately doesn't handle the case well where SpokePool implementations differ between chains...TBH I'm not sure yet how to handle that. We could maintain a mapping of chain ID --> git commit hash but this is better than what we currently have where one's best guess is that master matches deployed but that's not true pretty frequently

How about having a tag for each contract that gets updated when it's (re)deployed? For example spokepool-arbitrum-deployed. It implies a little bit of management, but we don't deploy all that often.

So that means we'd need to maintain N different tags for N chains with SpokePools? You think that's worth it?

@nicholaspai nicholaspai merged commit b4a0108 into master Dec 28, 2023
@nicholaspai nicholaspai deleted the nicholaspai-patch-1 branch December 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants