-
Notifications
You must be signed in to change notification settings - Fork 75
improve(README): Add details about deployed contract versions #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should move the `deployed` tag to whichever contract version we end up deploying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By deployed do you mean a git tag that gets updated each time we make a new deployment? If so, does that work in the case that we add a new chain? Then we'd be marking deployed against the entire state of the repository, but there might have been some minor adjustments to other contracts that were not re-deployed afterwards.
I think we should move up the |
How about having a tag for each contract that gets updated when it's (re)deployed? For example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
So that means we'd need to maintain N different tags for N chains with SpokePools? You think that's worth it? |
We should move the
deployedtag to whichever contract version we end up deploying