feat: Create USSLib #369
Merged
feat: Create USSLib #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Breaking changes from existing `SpokePool` types of same name:
## RelayData
- `relayerFeePct`/ `realizedLpFeePct` replaced with `outputAmount`. The total fee is implied to be difference between `inputAmount` - `outputAmount` * `exchangeRateInputOutputTokens`
- Fill `expiryTimestamp`
- Exclusive `relayer`
## RelayExecution
- No `maxCount`
- `bool isSlowRelay` has been replaced with an enum `executionType` which is also added to the `SlowFill` struct so that creator of SlowFill leaf can specify whether this is a deposit refund or a normal slow fill. This is designed to be used by the executor to filter out slow fills with messages that it *shouldn't* execute versus deposit refunds that it *should* execute.
- Updatable deposit fields are optimistically set to:
- outputAmount
- recipient
- message
## SlowFill
- Allow slow fill creator to specify `executionType` to distinguish between deposit refunds and normal slow fills. Deposit refunds should have a `message` field set to help the `depositCallbackAddress` determine the deposit that was refunded but this should still be executed by executor. Typically executors won't execute slow fills with messages.
## FundsDeposited
- Adds `depositRefundCallbackAddress` to rest of `RelayData` params. Can be used by dataworker to create a deposit refund as a slow fill leaf.
# Optimizing compilation of contracts
Unfortunately, adding more functions to the `SpokePool` will push it over the contract bytecode size unless we decrease the optimizer. Not sure how to get around this since we want to maintain old functionality so we can only add to the size. I've bumped it down by 100x to the point where the compiler doesn't warn anymore
ACX-1672 Add new contract structs
There will be a new RelayData struct for new Deposits, which means that the relayHash for new fills will be different.
|
nicholaspai
commented
Nov 9, 2023
pxrl
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 13, 2023
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
mrice32
reviewed
Nov 13, 2023
pxrl
reviewed
Nov 14, 2023
pxrl
reviewed
Nov 14, 2023
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
mrice32
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes from existing
SpokePooltypes of same name:Fixes ACX-1672
RelayData
relayerFeePct/realizedLpFeePctreplaced withoutputAmount. The total fee is implied to be difference betweeninputAmount-outputAmount*exchangeRateInputOutputTokensexpiryTimestamp/fillDeadlinerelayerRelayExecution
maxCountOptimizing compilation of contracts
Unfortunately, adding more functions to the
SpokePoolwill push it over the contract bytecode size unless we decrease the optimizer. Not sure how to get around this since we want to maintain old functionality so we can only add to the size. I've bumped it down by 100x to the point where the compiler doesn't warn anymore