feat: Hyperevm Spokepool #1106
feat: Hyperevm Spokepool #1106
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Whenever this is ready, you'll also need to add the spoke pool proxy address to |
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
| FILL_DEADLINE_BUFFER, | ||
| USDC[spokeChainId] ?? ZERO_ADDRESS, | ||
| // USDC[spokeChainId] ?? ZERO_ADDRESS, | ||
| "0xb88339CB7199b77E23DB6E890353E22632Ba630f", // USDC on HyperEVM |
There was a problem hiding this comment.
Before we merge this, we should get this fixed I think
| "contracts": { | ||
| "SpokePool": { | ||
| "address": "0xe7cb3e167e7475dE1331Cf6E0CEb187654619E12", | ||
| "address": "0xb234cA484866c811d0e6D3318866F583781ED045", |
There was a problem hiding this comment.
This is expected, right?
There was a problem hiding this comment.
It is, but I think we should be getting it in separately (...in advance) of this PR. We should really avoid mixing changes like this because it's easy to get mixed up. Flagged previously here: https://github.com/across-protocol/contracts/pull/1104/files/1a3bc006101a52fac9d42f53e1d2b68664d32736#r2348775844
There was a problem hiding this comment.
moved the extra changes here
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
force-pushed
the
faisal/hyperevm-spokepool
branch
from
4858105 to
c5216fe
Compare
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
force-pushed
the
faisal/hyperevm-spokepool
branch
from
b9a3d4b to
559b975
Compare
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
| }, | ||
| "Lens_Adapter": { | ||
| "address": "0x63AC22131eD457aeCbD63e6c4C7eeC7BBC74fF1F", | ||
| "address": "0x5e0B7e20a77BDf11812837D30F1326068Bcf24Cf", |
There was a problem hiding this comment.
Why are so many contracts unrelated to 999 changing in this file?
No description provided.