- 
                Notifications
    
You must be signed in to change notification settings  - Fork 75
 
feat(Foundry): Part 1 - Added address extraction script #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Review the following changes in direct dependencies. Learn more about Socket for GitHub. 
  | 
    
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
ed6035f    to
    6a2adf7      
    Compare
  
    Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two q's
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
| 
           @fusmanii Did we look at   | 
    
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
37c4b53    to
    1db9230      
    Compare
  
    | 
           @pxrl first time hearing about https://github.com/wighawag/forge-deploy, taking a look  | 
    
| 
           @grasphoper yeah I agree, I just tried forge-deploy, the implementation is not complete and it crashes on deployments file generation  | 
    
          
 Ah, I hadn't spotted that. 9 months with no activity is a bit of a red flag, though the author does otherwise have a really solid track record. If it worked and solved our use case then I think it'd at least be worth evaluating further, but if it doesn't work that's a showstopper. In general I just want to be sure that we've researched and evaluated any off-the-shelf tooling for this - we're not the only project with this use-case so it seems really odd that it's so under-served.  | 
    
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
912607e    to
    ebc36ce      
    Compare
  
    
Splitting this #1044 into multiple PRs
Part 1: Extract addresses script that generates
DeployedAddresses.solthat can be used in foundry deploy scriptsAfter every deploy, just need to run
yarn extract-addressesand deployed addresses contract will get updated with the latest addresses frombroadcastfolder anddeployments.jsonfileMore info in the attached EXTRACT_ADDRESSES.md
Diff is large because of the
broadcast/deployed-addresses.jsonandbroadcast/deployed-addresses.mdfiles