fix(svm): use bytes32 for foreign amounts #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Reinis-FRP
requested review from
mrice32,
nicholaspai,
chrismaree,
md0x,
pxrl and
bmzig
as code owners
Reinis-FRP
commented
Jun 11, 2025
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
mrice32
approved these changes
Jun 13, 2025
md0x
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Across on SVM should support foreign token amounts that could potentially not fit in the
u64type. This changes the type to[u8; 32]which would now apply tooutput_amountfor deposits andinput_amountfor fills and slow fills. The proposed implementation uses these same raw values in event logs and it is expected that Across protocol UMIP would dictate to use big-endianess encoding for these types when matching deposits/fills on EVM chains.