-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Description
Some chain-specific SpokePools lack tests, which could lead to potential issues, as these functionalities may not have been validated thoroughly.
The SpokePool files are located in the contracts/contracts
directory, while the tests should be added in the test/evm/hardhat/chain-specific-spokepools
directory.
Tests need to be added for the following spoke pools:
- AlephZero_SpokePool
- Base_SpokePool
- Blast_SpokePool
- Boba_SpokePool
- Ink_SpokePool
- Lisk_SpokePool
- Mode_SpokePool
- Ovm_SpokePool
- Redstone_SpokePool
- WorldChain_SpokePool
- Zora_SpokePool
Impact
- Lack of automated testing increases the risk of undetected bugs
- Makes it harder to verify contract behaviour across different chain implementations
- Could affect the reliability of cross-chain operations
Proposed Solution
Add comprehensive test files for each missing spoke pool implementation following existing test patterns from files like Arbitrum_SpokePool.ts
and Ethereum_SpokePool.ts
.
Tasks
- Create test files in
test/evm/hardhat/chain-specific-spokepools
for each listed spoke pool. - Implement standard test cases covering core functionality.
- Add chain-specific test cases where needed.
Metadata
Metadata
Assignees
Labels
No labels