Skip to content

Set default pixel scale to 1 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nclack merged 1 commit into from
Apr 5, 2024
Merged

Set default pixel scale to 1 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ impl Default for StorageProperties {
filename: Default::default(),
external_metadata_json: Default::default(),
first_frame_id: Default::default(),
pixel_scale_um: Default::default(),
pixel_scale_um: (1., 1.), // Default to 1.0 um/pixel (square pixels)
acquisition_dimensions: Default::default(),
enable_multiscale: Default::default(),
}
Expand Down
5 changes: 5 additions & 0 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ def test_set():
assert t.enable


def test_storage_properties_pixel_scale_defaults_to_1():
storage = acquire.StorageProperties()
assert storage.pixel_scale_um == (1.0, 1.0)


def test_list_devices(runtime: Runtime):
dm = runtime.device_manager()
for d in dm.devices():
Expand Down