Skip to content

Fix storage device id switching bug #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliddell merged 1 commit into from
Jan 18, 2024
Merged

Fix storage device id switching bug #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acquire-common
Open in desktop
Submodule acquire-common updated 4 files
+4 −0 CHANGELOG.md
+1 −0 acquire-driver-common/tests/integration/CMakeLists.txt
+244 −0 acquire-driver-common/tests/integration/switch-storage-identifier.cpp
+0 −3 acquire-video-runtime/src/runtime/sink.c
25 changes: 24 additions & 1 deletion tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import logging
import os
import time
from datetime import timedelta
from time import sleep
Expand Down Expand Up @@ -616,7 +617,29 @@ def test_invalidated_frame(runtime: Runtime):
runtime.stop()


# FIXME: (nclack) awkwardness around references (available frames, f)
def test_switch_device_identifier(
runtime: Runtime, request: pytest.FixtureRequest
):
p = acquire.setup(runtime, "simulated.*empty", "trash")
assert p.video[0].storage.identifier.name == "trash"
p = runtime.set_configuration(p)

dm = runtime.device_manager()
p.video[0].storage.identifier = dm.select(DeviceKind.Storage, "tiff")
p.video[0].storage.settings.filename = f"{request.node.name}.tif"
p = runtime.set_configuration(p)
assert p.video[0].storage.identifier.name == "tiff"

runtime.start()
runtime.stop()

# will raise an exception if the file doesn't exist or is invalid
with tifffile.TiffFile(p.video[0].storage.settings.filename):
pass

# cleanup
os.remove(p.video[0].storage.settings.filename)


# NOTES:
#
Expand Down