Acquisition dimension order in storage API#32
Merged
aliddell merged 24 commits intoacquire-project:mainfrom Feb 14, 2024
Merged
Conversation
2 tasks
…able-append-dimension-in-storageproperties
…storageproperties
andy-sweet
reviewed
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.c
Outdated
Show resolved
Hide resolved
aliddell
commented
Jan 31, 2024
aliddell
commented
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.c
Outdated
Show resolved
Hide resolved
aliddell
commented
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.c
Outdated
Show resolved
Hide resolved
aliddell
commented
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.c
Outdated
Show resolved
Hide resolved
aliddell
commented
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.h
Outdated
Show resolved
Hide resolved
aliddell
commented
Jan 31, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.h
Outdated
Show resolved
Hide resolved
nclack
approved these changes
Feb 14, 2024
acquire-core-libs/src/acquire-device-properties/device/props/storage.h
Outdated
Show resolved
Hide resolved
acquire-core-libs/src/acquire-device-properties/device/props/storage.c
Outdated
Show resolved
Hide resolved
aliddell
added a commit
to acquire-project/acquire-python
that referenced
this pull request
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to specify the names, ordering, and number of acquisition dimensions.