Skip to content

Conversation

@dadarya0
Copy link
Contributor

@dadarya0 dadarya0 commented Dec 20, 2023

@dadarya0 dadarya0 requested a review from fedys December 21, 2023 05:53
Copy link
Contributor

@tejasync tejasync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dadarya0!

Copy link
Contributor

@rahuld-dev rahuld-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dadarya0
Tested on QA env and it is working as expected.
https://rd-qa02.qa.acs.acquia.io/s/segments/view/1

@dadarya0 dadarya0 merged commit bf5491f into staging Dec 28, 2023
@dadarya0 dadarya0 deleted the MAUT-11028 branch December 28, 2023 06:53
@escopecz
Copy link
Contributor

escopecz commented Jan 4, 2024

This PR is breaking this plugin for the community with error message:

Fatal error: Uncaught Error: Undefined constant Mautic\LeadBundle\LeadEvents::LIST_FILTERS_MERGE in plugins/CustomObjectsBundle/EventListener/SegmentFiltersMergeSubscriber.php:27

We have to push https://github.com/acquia/mc-cs/pull/2105 to M4 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants