Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unregisterJob to ProgressManager #236

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Add unregisterJob to ProgressManager #236

merged 1 commit into from
Jun 22, 2023

Conversation

mdonaka
Copy link
Contributor

@mdonaka mdonaka commented Jun 22, 2023 •
edited
Loading

Summary

Fix progress log

Purpose

Stops progress log in the event of an error.

Contents

  • Add unregisterJob to ProgressManager

Testing Methods Performed

  • Throw during join and check the stop of log
  • CI

@mdonaka mdonaka marked this pull request as ready for review June 22, 2023 06:37
@mdonaka mdonaka merged commit edf3655 into main Jun 22, 2023
@mdonaka mdonaka deleted the feature/nakata/remove_progress branch June 22, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdonaka