Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to be able to launch QuickMPC in terraform.  #186

Merged
merged 31 commits into from
May 23, 2023

Conversation

KotaTakahashi9320
Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 commented May 19, 2023

Summary

Fix to be able to launch QuickMPC in terraform

Purpose

To make it easy to start up QuickMPC

Contents

Add tf file for deploy
Fix README.md

Testing Methods Performed

Deploy based on the README.md created
Then run demo from client

@KotaTakahashi9320 KotaTakahashi9320 force-pushed the feature/takahashi/deploy_terraform branch from 6bb83ac to 5085e8f Compare May 22, 2023 12:49
@KotaTakahashi9320 KotaTakahashi9320 changed the title Feature/takahashi/deploy terraform Fix to be able to launch QuickMPC in terraform.  May 23, 2023
@KotaTakahashi9320 KotaTakahashi9320 marked this pull request as ready for review May 23, 2023 05:42
Copy link
Collaborator Author

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo/terraform/deploy→demo/terraform/application
demo/deploy→demo/hoge ex)src,deploy_files etc

instance_countはbtsも含む数とコメントを追加

@@ -0,0 +1,99 @@
locals {
party_num = local.instance_count - 1
bts_num = local.instance_count - 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bts_num = local.instance_count - 1
bts_id = local.instance_count - 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

party_str=$2
image_tag=$3

((party_num++))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

適宜コメント追加

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo/README.md Outdated
```
make deploy-quickmpc
```
4. GCPのネットワーク設定で{variable.tfで設定したinstance_name}-vpc-*ネットワークのファイアウォール設定を変更する. <br>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4は不要
しかし、5000番ポートは空いていることをREADME.mdを追記

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KotaTakahashi9320
Copy link
Collaborator Author

@come2ry
I have corrected the areas you reviewed.
Please check it again.

Copy link
Contributor

@come2ry come2ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KotaTakahashi9320 KotaTakahashi9320 merged commit 05a7fa3 into main May 23, 2023
@KotaTakahashi9320 KotaTakahashi9320 deleted the feature/takahashi/deploy_terraform branch May 23, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants