-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to be able to launch QuickMPC in terraform. #186
Conversation
6bb83ac
to
5085e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo/terraform/deploy→demo/terraform/application
demo/deploy→demo/hoge ex)src,deploy_files etc
instance_countはbtsも含む数とコメントを追加
demo/terraform/deploy/deploy.tf
Outdated
@@ -0,0 +1,99 @@ | |||
locals { | |||
party_num = local.instance_count - 1 | |||
bts_num = local.instance_count - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bts_num = local.instance_count - 1 | |
bts_id = local.instance_count - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo/deploy/prepare_deploy.sh
Outdated
party_str=$2 | ||
image_tag=$3 | ||
|
||
((party_num++)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
適宜コメント追加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo/README.md
Outdated
``` | ||
make deploy-quickmpc | ||
``` | ||
4. GCPのネットワーク設定で{variable.tfで設定したinstance_name}-vpc-*ネットワークのファイアウォール設定を変更する. <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4は不要
しかし、5000番ポートは空いていることをREADME.mdを追記
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@come2ry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Fix to be able to launch QuickMPC in terraform
Purpose
To make it easy to start up QuickMPC
Contents
Add tf file for deploy
Fix README.md
Testing Methods Performed
Deploy based on the README.md created
Then run demo from client