Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE : division between two Shares #157

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

sakamoto-souta
Copy link
Collaborator

Summary

DELETE : division between two Shares

Purpose

to delete division which is unused

Contents

delete division and the parts which depend on division

Testing Methods Performed

make test t=./computation_container p=medium

Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Please check comments.

packages/server/computation_container/share/share.hpp Outdated Show resolved Hide resolved
packages/server/computation_container/optimizer/BUILD Outdated Show resolved Hide resolved
Copy link
Contributor

@watason watason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arukuka arukuka merged commit 5d0d080 into main Apr 12, 2023
@arukuka arukuka deleted the feature/sakamoto/delete_division branch April 12, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants