Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring docker-compose.yml & tester & debugger #126

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Refactoring docker-compose.yml & tester & debugger #126

merged 7 commits into from
Feb 21, 2023

Conversation

come2ry
Copy link
Contributor

@come2ry come2ry commented Feb 20, 2023

Summary

Refactoring testar & debugger

Purpose

  • To make docker-compose.yml loosely coupled and to facilitate docker-compose modification

Contents

  • Modified settings.json to automatically sort and format when saving yml in vscode.
    • Update README.md
  • Split scripts/docker-compose.yml into separate files
    • Fixed dependent shellscripts.

Testing Methods Performed

make test
make debug
CI

@come2ry come2ry changed the title Refactoring testar & debugger Refactoring docker-compose.yml & testar & debugger Feb 20, 2023
@come2ry come2ry merged commit a11ed72 into main Feb 21, 2023
@come2ry come2ry deleted the feature/tanaka/change-scripts-docker-compose branch February 21, 2023 03:52
@come2ry come2ry changed the title Refactoring docker-compose.yml & testar & debugger Refactoring docker-compose.yml & tester & debugger Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonaka mdonaka mdonaka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@come2ry @mdonaka