Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to use claims as information. #122

Merged
merged 42 commits into from
Feb 17, 2023
Merged

Modify to use claims as information. #122

merged 42 commits into from
Feb 17, 2023

Conversation

KotaTakahashi9320
Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 commented Feb 16, 2023

Summary

Modify to use claims as information.

Purpose

config.json is still there because the information in the claim is not used.

Contents

Delete config.json
Modify to use claims as information.
Fix test

Testing Methods Performed

CI

@KotaTakahashi9320 KotaTakahashi9320 changed the title Feature/takahashi/jwt Modify to use claims as information. Feb 16, 2023
@KotaTakahashi9320 KotaTakahashi9320 marked this pull request as ready for review February 16, 2023 08:15
@KotaTakahashi9320
Copy link
Collaborator Author

@arukuka
I have corrected the points you raised.
I would appreciate your confirmation.

Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KotaTakahashi9320 Thank you!
I commented on the point of concern, so please check it.

Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@arukuka arukuka merged commit 986b919 into main Feb 17, 2023
@arukuka arukuka deleted the feature/takahashi/jwt branch February 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants