Skip to content

Commit

Permalink
Merge pull request #263 from acompany-develop/feature/nakata/fix_comment
Browse files Browse the repository at this point in the history
Fix comment
  • Loading branch information
mdonaka authored Jul 21, 2023
2 parents 8f802a6 + 6c26cda commit aac1498
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion packages/client/libclient-py/quickmpc/pandas/readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def read_csv(*args, index_col: str, **kwargs) -> pd.DataFrame:
df = pd.read_csv(*args, **kwargs)
# ID列を数値化
df[index_col] = df[index_col].map(lambda x: to_float(x))
# join時にQMPCのCC側でID列でsortできる様に、座圧を行いindexに設定しておく
# send_share時にID列でsortできる様にID列を座標圧縮した列を追加する
df["__qmpc_sort_index__"] = df.index
df = df.sort_values(by=index_col)
df = df.reset_index(drop=True)
Expand Down
1 change: 0 additions & 1 deletion packages/client/libclient-py/quickmpc/utils/make_pieces.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def make_pieces(_, __):

@staticmethod
def check_max_size(max_size: int):
# NOTE: Couchbaseのアイテムサイズ上限:1MB
# NOTE: grpcの送受信データサイズ上限:4MB
lower_limit_size: int = 1
upper_limit_size: int = 1_000_000
Expand Down

0 comments on commit aac1498

Please sign in to comment.