Open
Conversation
So far, I've worked on reworking the Landing page for both desktop and mobile interfaces based on the Figma design. TODOs: 1. Image quality (Instagram icon, linkedin icon, youtube icon, acm icon, and the triangles) is subpar... 2. Not sure what the 'on hover' behavior for the register button should be, so I let it be for the time being. 3. I couldn't find an Ultra condensed Modenra woff2 file off the internet so I'm using a Moderna placeholder for now. On that note, the current file I'm using doesn't have a ?, so I'm using ? from another font. 4. Need to clean up the code and improve image names later. 5. Need to add an actual video in the placeholder area. 6. The triangles are slightly problematic, but I'll talk about it during our meeting. 7. Not sure where "Click here" should route the user to. 8. I couldn't tell what the Register font was from the Figma file so I used Sunday Masthead.
1. No login page for non admin users? 2. Can't go back to landing page without the back button - is this desirable behavior? 3. White register button on header vs pink register button on form 4. What does form register button do? ie what happens after registration? 5. Looking for other events? Not sure what goes here 6. I'd like to set up the admin page as well but what's the route for it? How do we know who admin users are? Admin only has log in, no register - so are we (devs) configuring admins?
- Added Viewport. Pls check this on bigger screens. - Fixed width header and entire page? what about marquee ie infinite scrolling thing? Need Luke or someone with a bigger screen to test this. Feel free to check its behavior (scroll speed, etc). - Cluttered bottom half? Thoughts? - Triangle side art behavior on bigger screens needs to be looked at - Rounded edges for images? Registration page uses rounded edges and I think it's good to be consistent - Overall testing on bigger screen sizes is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


So far, I've worked on reworking the Landing page for both desktop and mobile interfaces based on the Figma design. Link with evidence for a quick view: https://screenrec.com/share/hJqc516KyL.
TODOs for this page:
Next steps: