Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dns_doapi #5158

Merged
merged 1 commit into from
Sep 21, 2024
Merged

update dns_doapi #5158

merged 1 commit into from
Sep 21, 2024

Conversation

henrikalves
Copy link
Contributor

Hi,
we are moving our API endpoint to a different subdomain (the old one will continue to work for now),
dns_do does not exist anymore so I have removed it from the text.

The tests are failing due to the acmetestXyzRandomName. subdomain that is being used in the tests, the api of ours currently only allows subdomains starting with "_acme-challenge.", why is this a requirement now? I can see nowhere in the RFC 8555 that subdomains not starting with "_acme-challenge." are allowed.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@henrikalves
Copy link
Contributor Author

Please read the message above why the tests are failing, i have read the guide

@Neilpang Neilpang merged commit e036eea into acmesh-official:dev Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants