Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_njalla: fix record_id grep when removing record #5121

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

alfredfo
Copy link

Before remove-record would fail with
response='{"error": {"code": -32000, "message": "Invalid arguments"}, "jsonrpc": "2.0"}'
because record_id would always be empty.

Signed-off-by: Alfred Persson Forsberg cat@catcream.org

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Before remove-record would fail with
response='{"error": {"code": -32000, "message": "Invalid arguments"}, "jsonrpc": "2.0"}'
because record_id would always be empty.

Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
@alfredfo alfredfo changed the base branch from master to dev April 29, 2024 07:40
@alfredfo
Copy link
Author

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

asdasdsad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant