Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Alviy provider #5117

Merged
merged 20 commits into from
Sep 13, 2024
Merged

New Alviy provider #5117

merged 20 commits into from
Sep 13, 2024

Conversation

alviy
Copy link
Contributor

@alviy alviy commented Apr 27, 2024

Hello Acme Team!

Kindly ask to add Alviy DNS provider. All DNS tests are passed. It was hard work :-/

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@alviy alviy changed the title New Aliviy provider New Alviy provider Apr 27, 2024
@alviy
Copy link
Contributor Author

alviy commented May 13, 2024

@alviy
Copy link
Contributor Author

alviy commented Jun 10, 2024

@Neilpang could you review this PR please?

Thanks a lot!

@alviy
Copy link
Contributor Author

alviy commented Jul 3, 2024

@Neilpang could you please look at the commit comments?

@Neilpang Neilpang merged commit 5a20ce8 into acmesh-official:dev Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants