ci: re-pin internal action refs to v1.5.0 (A-618)#75
Conversation
The reusable workflows pinned their sibling composite actions to `@7f543be # v0.8.0` — a backfill artefact from A-585, chosen to avoid a self-reference when v1.0.0 was cut by hand (v0.8.0 was the last tag before the release commit). Now that the repo ships v1.x, move those internal pins forward to v1.5.0 so the workflows stop pinning to an old version of themselves. Also bumps the `load-repo-config` pin off its interim A-779 SHA onto the same v1.5.0 commit. No functional change: the referenced composite-action content is byte-identical between the old pins and v1.5.0 (verified by tree-SHA comparison). Refs A-618.
📝 WalkthroughWalkthroughReusable build, test, lint, and repository-configuration workflows now pin shared composite actions to the v1.5.0 commit. A changelog entry records the re-pinning and confirms callers remain on the reusable workflows’ ChangesWorkflow action re-pinning
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Claude finished @RobEasthope's task in 1m 23s —— View job Code Review — PR #75
Verdict: LGTM — clean, mechanical, low-risk. All 12 pin changes are consistent and the scope is correctly bounded. Workflow pins (
|
| File | Actions re-pinned |
|---|---|
reusable-build-test.yml |
6 (setup-project, build, typecheck, test-vitest, shellcheck, test-bats) |
reusable-lint.yml |
5 (setup-project, eslint, lint-markdown, lint-yaml, changelog-validate) |
reusable-load-repo-config.yml |
1 (load-repo-config) |
The reusable-load-repo-config.yml pin moves from a bespoke interim SHA (ab96ef... # A-779) rather than v0.8.0 — the in-code comment update from # A-779 to # v1.5.0 correctly reflects that.
reusable-pkg-release.yml is correctly left alone; its @d0a5949 pins differ in content and are called out as a separate follow-up in the PR body.
Changelog entry
category: chore,breaking: false, correct branch and issue (A-618) — all accurate.- Body covers both the 11
v0.8.0-origin pins and the singleload-repo-configA-779 pin in separate bullets, consistent with the diff. - The closing paragraph ("No consumer-facing change…") accurately reflects the byte-identity claim.
Minor observation (no action needed)
The PR description phrases it as "12 internal composite-action pins (and one load-repo-config pin)" — implying 13 total — but the diff is 12 lines (11 from v0.8.0 + 1 from A-779). The code and changelog are correct; the body prose is just slightly ambiguous. Not worth a revision.
triage-pr — review feedback summaryAcknowledging the issue-level review feedback (no resolvable thread per finding):
|
Summary
@ba77002 # v1.5.0— 11 off the backfill-era@7f543be # v0.8.0, plus oneload-repo-configpin off its interim A-779 SHA.@v1; only the internal action-to-action pins move.no release (ci-only)—.github/workflows/*.ymledits with no behaviour change; the PR title is intentionallyci:so release-please cuts no bump.Files:
reusable-lint.yml(5 pins),reusable-build-test.yml(6 pins),reusable-load-repo-config.yml(1 pin) — 12 in total.Out of scope (separate follow-up, A-959):
reusable-pkg-release.yml'ssetup-project/build @d0a5949pins — those point at a pre-release snapshot whose content differs from v1.5.0, so bumping them is a real change needing verification, not this cosmetic pass.Related Issues
Test Plan
GO / NO GOaggregator green (incl. actionlint +📓 Changelogentry validation)