Ruby services cleanup #37
Conversation
|
I will wait until after @bcongdon merges |
| @@ -1,11 +1,10 @@ | |||
| CREATE DATABASE IF NOT EXISTS groot_caffeine_service_dev; | |||
There was a problem hiding this comment.
Does caffeine service not need a database anymore?
There was a problem hiding this comment.
Caffeine was always groot-merch-service (the database name specified was probably named this at one point before we made the change to rename caffeine to merch). We made the database change name everywhere so I'm pretty sure this is not needed anymore.
sameetandpotatoes
force-pushed
the
rename_yaml_keys
branch
from
6c5da1d to
ef4fa12
Compare
|
Ready for a look from @bcongdon and @narendasan. |
|
Most of these changes and the changes in the PRs listed look fine, will wait on @bcongdon to take a look as well. Made a comment on one of the repos but its just a usability thing |
|
So are the test databases just used for unit testing (i.e. not development)? If so, then this is probably good-to-go. |
|
Yep exactly. Just to allow docker to be used for development and for those
who have tests for their services.
On Tue, May 16, 2017, 6:47 PM Ben Congdon ***@***.***> wrote:
So are the test databases just used for unit testing (i.e. not
development)? If so, then this is probably good-to-go.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADcOoEUvOnMnCxFoYXywkdwwvElanWoBks5r6jWhgaJpZM4Nb1FS>
.
--
Sameet Sapra
Computer Science Major, Statistics Minor
University of Illinois Urbana-Champaign | Class of 2019
sameetsapra.com
|
3 participants
This PR (or set of PRs, see below) standardizes a bunch of things for the Ruby services with docker and in general (Ben has done this for all Python services). Specifically:
_devnamesRecruiterTokenOther PRs with this:
To make sure this is done correctly in prod, I think we need to rename the databases in the docker db container as well, as well as update all the config files.