extract_loudness: Fixing #31 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting and make the function differentiable
gudgud96
reviewed
Dec 31, 2021
| assert (block_size is None) != (frame_rate is None), "Specify exactly one of block_size or frame_rate" | ||
|
|
||
| if frame_rate is not None: | ||
| block_size = sample_rate // frame_rate |
There was a problem hiding this comment.
minor thingy: should be sampling_rate here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a version of
extract_loudnessthat is almost a 1:1 copy of the fixed version of the magenta/ddspcompute_loudness. The changes are mostly:In contrast to magenta/ddsp, this version does not have dynamic range and ref_db, but I don't understand the concepts behind those and doubt that they are necessary.
There seem to be small numerical errors that prevent the curve from being 100% smooth, but this is something one can live with I hope: