add musl targets

[achristmascarl]

• add musl test suites
• add musl targets to cd
• test new targets with ci

---

Important

Add musl targets to CI/CD workflows and suppress clippy warnings for large enum variants.

• CI/CD Workflows:
  • Add musl targets x86_64-unknown-linux-musl and aarch64-unknown-linux-musl to cd.yml and ci.yml.
  • Test new musl targets in CI workflow.
• Code Changes:
  • Suppress clippy::large_enum_variant warnings in src/app.rs, src/components/data.rs, and src/popups/mod.rs.

^{This description was created by for 63300b7. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to ac84ed3 in 2 minutes and 21 seconds

More details

• Looked at 127 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 10 drafted comments based on config settings.

1. .github/workflows/cd.yml:69

• Draft comment:
  Added musl targets for Linux. Ensure that all required cross-compilation dependencies for musl (e.g. musl libc) are installed on the runner.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the PR author to ensure that dependencies are installed, which violates the rule against asking the author to ensure things are tested or verified. It doesn't provide a specific code suggestion or ask for a specific test to be written.

2. .github/workflows/cd.yml:111

• Draft comment:
  Consider quoting the features string in build args to protect against spaces (e.g. features like "termux --no-default-features").
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. .github/workflows/ci.yml:38

• Draft comment:
  New musl CI targets added. Verify that the nightly toolchain used supports these musl targets.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the PR author to verify compatibility with the nightly toolchain, which falls under asking the author to double-check things. This violates the rules.

4. .github/workflows/ci.yml:222

• Draft comment:
  Again, consider quoting the features parameter in the build/cargo steps to accommodate features with spaces.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%

1. The features parameter is only set to "default" in the matrix. 2. There are no spaces in any of the feature strings. 3. The suggestion is technically correct - quoting would make it more robust. 4. However, since there are no spaces in the actual features used, this change isn't necessary. 5. Making unnecessary changes increases code churn without benefit.
   The suggestion would make the code more robust against future changes that might include spaces in features. Not quoting could cause issues if someone adds features with spaces later.
   While technically correct, we should avoid making changes that don't solve any current problems. If spaces in features become needed later, that would be the right time to add quotes.
   Delete the comment since it suggests a change that isn't necessary for the current code and doesn't fix any actual problems.

5. .github/workflows/ci.yml:15

• Draft comment:
  Environment variable CARGO_TARGET_I586_UNKNOWN_LINUX_MUSL_RUSTFLAGS is set in multiple jobs; ensure it correctly aligns with the actual target (i686 vs I586) used in the matrix.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. .github/workflows/cd.yml:67

• Draft comment:
  Musl targets added for x86_64 and aarch64 look consistent. Please confirm that the use-cross and features settings are appropriate for these targets.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

7. .github/workflows/ci.yml:37

• Draft comment:
  The CI matrix now includes musl targets with os-name labels (aarch64-musl, x86_64-musl). Verify that these labels are consistent with your logging/reporting expectations.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

8. .github/workflows/ci.yml:187

• Draft comment:
  In the test-publish job, the env variable CARGO_TARGET_I586_UNKNOWN_LINUX_MUSL_RUSTFLAGS is set for musl builds. Ensure this flag (and its naming) is applicable for x86_64 and aarch64 targets, as it may be intended for i686.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to ensure that a specific environment variable is applicable for certain targets. This falls under asking the author to ensure behavior, which is against the rules. The comment does not provide a specific suggestion or point out a clear issue, but rather asks for confirmation. Therefore, it should be removed.

9. .github/workflows/ci.yml:237

• Draft comment:
  Consider quoting variables in the tar and shasum commands to prevent issues with filenames containing spaces.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

10. .github/workflows/cd.yml:14

• Draft comment:
  Typo: The environment variable 'CARGO_TARGET_I586_UNKNOWN_LINUX_MUSL_RUSTFLAGS' appears to contain a typographical error. Typically, for 32-bit musl targets, the convention is to use 'i686' (as seen later in the file with target 'i686-unknown-linux-musl'). Please update 'I586' to 'I686' to ensure consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_h5UYBk12trCeFfr7

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on e87dd10 in 28 seconds

More details

• Looked at 36 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. src/app.rs:55

• Draft comment:
  Consider refactoring the enum if possible instead of suppressing clippy::large_enum_variant.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

2. src/components/data.rs:31

• Draft comment:
  Review if suppressing clippy warning on large enum (DataState) is necessary or if the enum structure could be optimized.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

3. src/popups/mod.rs:20

• Draft comment:
  Ensure that using #[allow(clippy::large_enum_variant)] on PopUpPayload is justified; consider simplifying variants if feasible.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

4. src/app.rs:55

• Draft comment:
  Avoiding clippy’s large_enum_variant warning by suppressing it is acceptable, but consider boxing large fields in enum variants if size is a concern.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

5. src/components/data.rs:31

• Draft comment:
  Suppressing large_enum_variant warning for DataState is OK; review if refactoring (e.g. boxing) might provide better performance/memory usage.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

6. src/popups/mod.rs:21

• Draft comment:
  The allowance on PopUpPayload hides clippy warnings. Consider explaining the rationale or boxing large variants if necessary.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

Workflow ID: wflow_8s6DuNEeVDqAErrz

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 63300b7 in 55 seconds

More details

• Looked at 78 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. .github/workflows/ci.yml:15

• Draft comment:
  The env variable CARGO_TARGET_I586_UNKNOWN_LINUX_MUSL_RUSTFLAGS is set globally even though some musl targets in the matrix (e.g. i686, x86_64, aarch64) don’t use the I586 variant. Consider adjusting per-target configuration.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. .github/workflows/ci.yml:179

• Draft comment:
  Removal of the 'test-publish' job may impact the publishing of musl target binaries. Ensure this deletion is intentional or provide an alternative publishing step if needed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. .github/workflows/ci.yml:15

• Draft comment:
  Typographical error: The environment variable 'CARGO_TARGET_I586_UNKNOWN_LINUX_MUSL_RUSTFLAGS' might be mistyped. Note that one of your matrix targets is 'i686-unknown-linux-musl' (line 35). Please verify if the variable should use 'I686' instead of 'I586'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. .github/workflows/ci.yml:29

• Draft comment:
  Cosmetic issue: There is a trailing space after 'ubuntu-latest' on line 29. This does not affect functionality but could be removed for consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_5L19kCQy5SGt3rBX

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Included in release v0.2.15