Calculation method different?

[semaf]

Hey,

I am having somehow totally wrong times.

The script gives:
03:13
12:51
16:54
20:15
22:31

Should be:
03:52
05:22 (sun)
12:56
16:57
20:21
21:41

Selected is Karachi

[achaudhry]

Hey, sorry for the late response. What location are you using, just so I can debug on my end? Thanks@

[semaf]

Bro I set the calculation method my own:

        # Calculation Methods
        methods = {
                'Diyanet': {
                        'name': 'Diyanet Isleri Baskanligi',
                        'params': { 'fajr': 18, 'isha': 18 },
                        'offsets': { 'fajr': -200, 'sunrise': -6, 'dhuhr': 7, 'asr': 4, 'maghrib': 7, 'isha': 1 } },

The coordinates for our location is 48.210033, 16.363449

Asr is set to "Hanafi"

The result is showing me
Fajr: 05:15
Sunrise: 08:04
Dhuhr: 11:40
Asr: 11:40
Maghrib: 16:14
Isha: 18:04
Midnight: 00:39

It should be by the correct calculation:
Fajr: 05:13
Sunrise: 06:57
Dhuhr: 11:44
Asr: 13:57
Maghrib: 16:22
Isha: 17:42
Midnight: 00:39
Source: https://www.namaztakvimi.com/avusturya/viyana-ezan-vakti.html

[semaf]

Sorry but your code is not working correct and is useless for the folk.

[achaudhry]

@semaf Hey, I'm sorry I haven't been able to look at the issue due to some personal reasons. I'll look at it in the next couple of days and report back.

Since you're using your own calculation method, I'd like to test it with your changes. Could you commit your code and send me the commit hash or create a pull request so that I can look into it? I have not heard any other complaints and I know there are many people out there using this so I assume it's broken for your specific use case. Happy to look into it if you can push your changes.

Thanks!

[semaf]

Thank you for your reply. Sorry for that.

I am not able to pull it at the moment but can paste here the files.
The output of times should equal to this here:
https://namazvakitleri.diyanet.gov.tr/en-US/11618/prayer-time-for-viyana

praytimes.py
https://pastebin.com/yNDLY0L1

updateAzaanTimers.py
https://pastebin.com/LhFVAkNk

Here is an example of the praytimes.py with Diyanet calculation method too but result is also not exact or not to change over any settings.
https://github.com/cpfair/pebble-qibla-www/blob/master/praytimes.py

[achaudhry]

Spent a few hours on this, can't figure out what's wrong. Will keep looking and let you know if I make any progress

[cmadooly]

Asalaamu'alykum @achaudhry - Coding is not really my area of expertise. I've got everything working except I want to change ASR to Hanafi time. Everything else about your script is working fine

05:55 (fajr) 13:28 (Duhr) 17:04 (Asr) 19:52 (Maghrib) 21:02 (Isha)

I just want Asr to be hanafi time, so it should be 18:04
Do you what I need to adjust?
I'm using the ISNA method
lat = 33.0151
long = -96.6130

[cmadooly]

Asalaamu'alykum @achaudhry - Coding is not really my area of expertise. I've got everything working except I want to change ASR to Hanafi time. Everything else about your script is working fine

05:55 (fajr) 13:28 (Duhr) 17:04 (Asr) 19:52 (Maghrib) 21:02 (Isha)

I just want Asr to be hanafi time, so it should be 18:04
Do you what I need to adjust?
I'm using the ISNA method
lat = 33.0151
long = -96.6130

Nevermind, figured it out
Not sure if this is the right way but in praytimes.py I changed
'ISNA': { 'name': 'Islamic Society of North America (ISNA)', 'params': { 'fajr': 15, 'isha': 15 } },
to

'ISNA': {
                        'name': 'Islamic Society of North America (ISNA)',
                        'params': { 'fajr': 15, 'asr': 2, 'isha': 15 } },

[achaudhry]

Wa Allaikum Assalam @cmadooly Sorry for the late response. The proper way to do it would be to add
PT.adjust({'asr': 'Hanafi'}) in updateAzaanTimers.py right after you set the Method to ISNA.

Hope this helps!

[achaudhry]

@cmadooly By the way, essentially the end result is exactly the same so you can either go with your solution or mine. Both should work just fine. But it's usually better not to hard code anything in praytimes.py to keep that class generic, and put application specific setup such as calculation method, asr method, lat/lng etc in updateAzaanTimers.py

Stay safe and healthy!

[cmadooly]

Thank you. I reverted my change and used yours.

[semaf]

So at least I got it running since couple of weeks with Logitech Media Server and AirPlay Speakers. Supporting multiple speakers around house.

Also the Diyanet is working with the calculation.
https://github.com/semaf/adhan/blob/master/praytimes.py

https://github.com/semaf/adhan/

Thank you bro for the code!

[achaudhry]

No problem brother. Sorry I couldn't spend more time to help you but I'm so happy to hear that you got it to work.

If the code is generic enough and you think it will help others in the future, do you want to submit a pull request with your change? I'll be happy to merge it.

Thank you!