Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-byte volumes for MINC. Also fixes #259. #281

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

rdvincent
Copy link
Collaborator

This pull request incorporates several related changes:

  1. Updates minc2volume-viewer.js and minc2volume-viewer.py to allow a command-line argument that sets the voxel type written to the raw file. This also adds a field to the header that indicates the voxel type.
  2. Updates minc.js to read this new voxel type and act accordingly.
  3. Creates a scanDataRange() utility function that is used by all volume loaders to set header.voxel_min and header.voxel_max.
  4. Tweaked the example's style sheet slightly, to make room for the larger voxel values.
  5. Finally, this fixes issue minc2volume-viewer.py requires python >= 3.3 #259 - minc2volume-viewer.py now runs under Python 2.7.

natacha-beck added a commit that referenced this pull request Nov 5, 2015
Support non-byte volumes for MINC. Also fixes #259.
@natacha-beck natacha-beck merged commit 70deb81 into aces:master Nov 5, 2015
@rdvincent rdvincent deleted the rdv-non-byte branch November 5, 2015 18:07
joelthelion pushed a commit to TonyChizat/brainbrowser that referenced this pull request Apr 11, 2016
Support non-byte volumes for MINC. Also fixes aces#259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants