-
Notifications
You must be signed in to change notification settings - Fork 181
[media] upload tab #9731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[media] upload tab #9731
Conversation
@adamdaudrich What was the issue exactly? |
This PR corrects a language ambiguity in the sweet alert error throw. There are conditions established in the code for the file name and I felt that the error msg could be a little more obvious. |
The file size thing is a separate issue connected to environment as @ridz1208 pointed out. Try uploading on Pierre Rioux wuz here and that should not happen. |
That's it for this one ! Merci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brief summary of changes
Testing instructions (if applicable)
Checkout this remote branch
npm run compile
Go to Clinical / Media
Enter :
MTL 023
,V1
,MRI Parameter Form
in the fields.create a file named
ROM162_V2_bmi.mp4
. Browse for it and hitUpload
You should see the following message:
Link(s) to related issue(s)