Skip to content

[media] upload tab #9731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

adamdaudrich
Copy link
Collaborator

@adamdaudrich adamdaudrich commented Mar 25, 2025

Brief summary of changes

  • Have you updated related documentation? NO. Testing not technically fully done because i am getting a "file too large" error as well. I opened a separate issue for that.

Testing instructions (if applicable)

  • Checkout this remote branch

  • npm run compile

  • Go to Clinical / Media

  • Enter : MTL 023 , V1, MRI Parameter Form in the fields.

  • create a file named ROM162_V2_bmi.mp4 . Browse for it and hit Upload

You should see the following message:

Screenshot from 2025-03-21 13-01-06

  • Replicate this by selecting new fields and attempting to upload a non-corresponding file name.
  • Assert that the error message asks for the filename indicated in the fields.
  • Try adding a file formatted the same way with spaces instead of underscores. Assert that the file is accepted.

Link(s) to related issue(s)

  • Resolves # 9721 (Reference the issue this fixes, if any.)

@adamdaudrich adamdaudrich added Module: media PR or issue related to media module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 25, 2025
@GeorgeMurad
Copy link
Contributor

@adamdaudrich What was the issue exactly?

@adamdaudrich
Copy link
Collaborator Author

@adamdaudrich What was the issue exactly?

This PR corrects a language ambiguity in the sweet alert error throw.

There are conditions established in the code for the file name and I felt that the error msg could be a little more obvious.

@adamdaudrich
Copy link
Collaborator Author

The file size thing is a separate issue connected to environment as @ridz1208 pointed out. Try uploading on Pierre Rioux wuz here and that should not happen.

@GeorgeMurad
Copy link
Contributor

I see the message now. which makes sense. Is there anything else?

image

@adamdaudrich
Copy link
Collaborator Author

That's it for this one ! Merci

Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: media PR or issue related to media module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants